Commit 092e1dc3 authored by Roland Dreier's avatar Roland Dreier Committed by Nicholas Bellinger

qla2xxx: Don't crash if we can't find cmd for failed CTIO

In qlt_do_ctio_completion(), there's no point in calling
qlt_term_ctio_exchange() with a NULL cmd -- all that it does is crash
in a NULL pointer dereference, since it does

	qlt_send_term_exchange(vha, cmd, &cmd->atio, 1);

and dereferencing &cmd->atio is a bad idea if cmd itself is NULL.

If we really need to do this, we could take the values from the
failed CTIO we're processing, but it's not clear if it's worth
the replumbing to do that.
Signed-off-by: default avatarRoland Dreier <roland@purestorage.com>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 3578ddba
...@@ -2477,11 +2477,9 @@ static void qlt_do_ctio_completion(struct scsi_qla_host *vha, uint32_t handle, ...@@ -2477,11 +2477,9 @@ static void qlt_do_ctio_completion(struct scsi_qla_host *vha, uint32_t handle,
} }
cmd = qlt_ctio_to_cmd(vha, handle, ctio); cmd = qlt_ctio_to_cmd(vha, handle, ctio);
if (cmd == NULL) { if (cmd == NULL)
if (status != CTIO_SUCCESS)
qlt_term_ctio_exchange(vha, ctio, NULL, status);
return; return;
}
se_cmd = &cmd->se_cmd; se_cmd = &cmd->se_cmd;
tfo = se_cmd->se_tfo; tfo = se_cmd->se_tfo;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment