Commit 0979e265 authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen

scsi: csiostor: Call scsi_done() directly

Conditional statements are faster than indirect calls. Hence call
scsi_done() directly.

Link: https://lore.kernel.org/r/20211007202923.2174984-27-bvanassche@acm.orgSigned-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent a75af82a
...@@ -1720,7 +1720,7 @@ csio_scsi_err_handler(struct csio_hw *hw, struct csio_ioreq *req) ...@@ -1720,7 +1720,7 @@ csio_scsi_err_handler(struct csio_hw *hw, struct csio_ioreq *req)
} }
cmnd->result = (((host_status) << 16) | scsi_status); cmnd->result = (((host_status) << 16) | scsi_status);
cmnd->scsi_done(cmnd); scsi_done(cmnd);
/* Wake up waiting threads */ /* Wake up waiting threads */
csio_scsi_cmnd(req) = NULL; csio_scsi_cmnd(req) = NULL;
...@@ -1748,7 +1748,7 @@ csio_scsi_cbfn(struct csio_hw *hw, struct csio_ioreq *req) ...@@ -1748,7 +1748,7 @@ csio_scsi_cbfn(struct csio_hw *hw, struct csio_ioreq *req)
} }
cmnd->result = (((host_status) << 16) | scsi_status); cmnd->result = (((host_status) << 16) | scsi_status);
cmnd->scsi_done(cmnd); scsi_done(cmnd);
csio_scsi_cmnd(req) = NULL; csio_scsi_cmnd(req) = NULL;
CSIO_INC_STATS(csio_hw_to_scsim(hw), n_tot_success); CSIO_INC_STATS(csio_hw_to_scsim(hw), n_tot_success);
} else { } else {
...@@ -1876,7 +1876,7 @@ csio_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmnd) ...@@ -1876,7 +1876,7 @@ csio_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmnd)
return rv; return rv;
err_done: err_done:
cmnd->scsi_done(cmnd); scsi_done(cmnd);
return 0; return 0;
} }
...@@ -1979,7 +1979,7 @@ csio_eh_abort_handler(struct scsi_cmnd *cmnd) ...@@ -1979,7 +1979,7 @@ csio_eh_abort_handler(struct scsi_cmnd *cmnd)
spin_unlock_irq(&hw->lock); spin_unlock_irq(&hw->lock);
cmnd->result = (DID_ERROR << 16); cmnd->result = (DID_ERROR << 16);
cmnd->scsi_done(cmnd); scsi_done(cmnd);
return FAILED; return FAILED;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment