Commit 098aafaa authored by YueHaibing's avatar YueHaibing Committed by David S. Miller

net: aquantia: cleanup err handing in hw_atl_utils_fw_rpc_wait

'err' always be 0 in the two places.
Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1115439f
...@@ -454,8 +454,6 @@ int hw_atl_utils_fw_rpc_wait(struct aq_hw_s *self, ...@@ -454,8 +454,6 @@ int hw_atl_utils_fw_rpc_wait(struct aq_hw_s *self,
(fw.val = (fw.val =
aq_hw_read_reg(self, HW_ATL_RPC_STATE_ADR), aq_hw_read_reg(self, HW_ATL_RPC_STATE_ADR),
fw.tid), 1000U, 100U); fw.tid), 1000U, 100U);
if (err < 0)
goto err_exit;
if (fw.len == 0xFFFFU) { if (fw.len == 0xFFFFU) {
err = hw_atl_utils_fw_rpc_call(self, sw.len); err = hw_atl_utils_fw_rpc_call(self, sw.len);
...@@ -463,8 +461,6 @@ int hw_atl_utils_fw_rpc_wait(struct aq_hw_s *self, ...@@ -463,8 +461,6 @@ int hw_atl_utils_fw_rpc_wait(struct aq_hw_s *self,
goto err_exit; goto err_exit;
} }
} while (sw.tid != fw.tid || 0xFFFFU == fw.len); } while (sw.tid != fw.tid || 0xFFFFU == fw.len);
if (err < 0)
goto err_exit;
if (rpc) { if (rpc) {
if (fw.len) { if (fw.len) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment