Commit 09fbca8e authored by Dennis Dalessandro's avatar Dennis Dalessandro Committed by Jason Gunthorpe

IB/hfi1: No need to use try_module_get for debugfs

The call in debugfs.c for try_module_get() is not needed. A reference to
the module will be taken by the VFS layer as long as the owner field is
set in the file ops struct. So set this as well as remove the call.
Suggested-by: default avatarJason Gunthorpe <jgg@mellanox.com>
Reviewed-by: default avatarMike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: default avatarDennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent 8bd516bd
...@@ -987,9 +987,6 @@ static int __i2c_debugfs_open(struct inode *in, struct file *fp, u32 target) ...@@ -987,9 +987,6 @@ static int __i2c_debugfs_open(struct inode *in, struct file *fp, u32 target)
struct hfi1_pportdata *ppd; struct hfi1_pportdata *ppd;
int ret; int ret;
if (!try_module_get(THIS_MODULE))
return -ENODEV;
ppd = private2ppd(fp); ppd = private2ppd(fp);
ret = acquire_chip_resource(ppd->dd, i2c_target(target), 0); ret = acquire_chip_resource(ppd->dd, i2c_target(target), 0);
...@@ -1155,6 +1152,7 @@ static int exprom_wp_debugfs_release(struct inode *in, struct file *fp) ...@@ -1155,6 +1152,7 @@ static int exprom_wp_debugfs_release(struct inode *in, struct file *fp)
{ \ { \
.name = nm, \ .name = nm, \
.ops = { \ .ops = { \
.owner = THIS_MODULE, \
.read = readroutine, \ .read = readroutine, \
.write = writeroutine, \ .write = writeroutine, \
.llseek = generic_file_llseek, \ .llseek = generic_file_llseek, \
...@@ -1165,6 +1163,7 @@ static int exprom_wp_debugfs_release(struct inode *in, struct file *fp) ...@@ -1165,6 +1163,7 @@ static int exprom_wp_debugfs_release(struct inode *in, struct file *fp)
{ \ { \
.name = nm, \ .name = nm, \
.ops = { \ .ops = { \
.owner = THIS_MODULE, \
.read = readf, \ .read = readf, \
.write = writef, \ .write = writef, \
.llseek = generic_file_llseek, \ .llseek = generic_file_llseek, \
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment