Commit 0aedc880 authored by Simon Ser's avatar Simon Ser

drm/atomic-helper: print message on driver connector check failure

Sometimes drivers are missing logs when they return EINVAL.
Printing the failure here in common code can help understand where
EINVAL is coming from.

All other atomic_check() calls in this file already have similar
logging.

v2: add missing newlines
Signed-off-by: default avatarSimon Ser <contact@emersion.fr>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: default avatarLyude Paul <lyude@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220829151451.152114-1-contact@emersion.fr
parent 981f0929
...@@ -702,8 +702,12 @@ drm_atomic_helper_check_modeset(struct drm_device *dev, ...@@ -702,8 +702,12 @@ drm_atomic_helper_check_modeset(struct drm_device *dev,
if (funcs->atomic_check) if (funcs->atomic_check)
ret = funcs->atomic_check(connector, state); ret = funcs->atomic_check(connector, state);
if (ret) if (ret) {
drm_dbg_atomic(dev,
"[CONNECTOR:%d:%s] driver check failed\n",
connector->base.id, connector->name);
return ret; return ret;
}
connectors_mask |= BIT(i); connectors_mask |= BIT(i);
} }
...@@ -745,8 +749,12 @@ drm_atomic_helper_check_modeset(struct drm_device *dev, ...@@ -745,8 +749,12 @@ drm_atomic_helper_check_modeset(struct drm_device *dev,
if (funcs->atomic_check) if (funcs->atomic_check)
ret = funcs->atomic_check(connector, state); ret = funcs->atomic_check(connector, state);
if (ret) if (ret) {
drm_dbg_atomic(dev,
"[CONNECTOR:%d:%s] driver check failed\n",
connector->base.id, connector->name);
return ret; return ret;
}
} }
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment