Commit 0b00fc58 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman

LEDS: fix race in device_create

There is a race from when a device is created with device_create() and
then the drvdata is set with a call to dev_set_drvdata() in which a
sysfs file could be open, yet the drvdata will be NULL, causing all
sorts of bad things to happen.

This patch fixes the problem by using the new function,
device_create_drvdata().

Cc: Kay Sievers <kay.sievers@vrfy.org>
Cc: Richard Purdie <rpurdie@rpsys.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 6c06aec2
...@@ -103,13 +103,11 @@ int led_classdev_register(struct device *parent, struct led_classdev *led_cdev) ...@@ -103,13 +103,11 @@ int led_classdev_register(struct device *parent, struct led_classdev *led_cdev)
{ {
int rc; int rc;
led_cdev->dev = device_create(leds_class, parent, 0, "%s", led_cdev->dev = device_create_drvdata(leds_class, parent, 0, led_cdev,
led_cdev->name); "%s", led_cdev->name);
if (IS_ERR(led_cdev->dev)) if (IS_ERR(led_cdev->dev))
return PTR_ERR(led_cdev->dev); return PTR_ERR(led_cdev->dev);
dev_set_drvdata(led_cdev->dev, led_cdev);
/* register the attributes */ /* register the attributes */
rc = device_create_file(led_cdev->dev, &dev_attr_brightness); rc = device_create_file(led_cdev->dev, &dev_attr_brightness);
if (rc) if (rc)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment