Commit 0b0e9cdb authored by Rob Herring (Arm)'s avatar Rob Herring (Arm) Committed by Jakub Kicinski

net: mdio: Use of_property_count_u32_elems() to get property length

Replace of_get_property() with the type specific
of_property_count_u32_elems() to get the property length.

This is part of a larger effort to remove callers of of_get_property()
and similar functions. of_get_property() leaks the DT property data
pointer which is a problem for dynamically allocated nodes which may
be freed.
Signed-off-by: default avatarRob Herring (Arm) <robh@kernel.org>
Link: https://patch.msgid.link/20240731201514.1839974-2-robh@kernel.orgSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 46e6acfe
...@@ -390,7 +390,7 @@ EXPORT_SYMBOL(of_phy_get_and_connect); ...@@ -390,7 +390,7 @@ EXPORT_SYMBOL(of_phy_get_and_connect);
bool of_phy_is_fixed_link(struct device_node *np) bool of_phy_is_fixed_link(struct device_node *np)
{ {
struct device_node *dn; struct device_node *dn;
int len, err; int err;
const char *managed; const char *managed;
/* New binding */ /* New binding */
...@@ -405,8 +405,7 @@ bool of_phy_is_fixed_link(struct device_node *np) ...@@ -405,8 +405,7 @@ bool of_phy_is_fixed_link(struct device_node *np)
return true; return true;
/* Old binding */ /* Old binding */
if (of_get_property(np, "fixed-link", &len) && if (of_property_count_u32_elems(np, "fixed-link") == 5)
len == (5 * sizeof(__be32)))
return true; return true;
return false; return false;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment