Commit 0b776b06 authored by Paul Gortmaker's avatar Paul Gortmaker

block: delete __cpuinit usage from all block files

The __cpuinit type of throwaway sections might have made sense
some time ago when RAM was more constrained, but now the savings
do not offset the cost and complications.  For example, the fix in
commit 5e427ec2 ("x86: Fix bit corruption at CPU resume time")
is a good example of the nasty type of bugs that can be created
with improper use of the various __init prefixes.

After a discussion on LKML[1] it was decided that cpuinit should go
the way of devinit and be phased out.  Once all the users are gone,
we can then finally remove the macros themselves from linux/init.h.

This removes all the drivers/block uses of the __cpuinit macros
from all C files.

[1] https://lkml.org/lkml/2013/5/20/589

Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
parent a83048eb
...@@ -189,7 +189,7 @@ void blk_iopoll_init(struct blk_iopoll *iop, int weight, blk_iopoll_fn *poll_fn) ...@@ -189,7 +189,7 @@ void blk_iopoll_init(struct blk_iopoll *iop, int weight, blk_iopoll_fn *poll_fn)
} }
EXPORT_SYMBOL(blk_iopoll_init); EXPORT_SYMBOL(blk_iopoll_init);
static int __cpuinit blk_iopoll_cpu_notify(struct notifier_block *self, static int blk_iopoll_cpu_notify(struct notifier_block *self,
unsigned long action, void *hcpu) unsigned long action, void *hcpu)
{ {
/* /*
...@@ -209,7 +209,7 @@ static int __cpuinit blk_iopoll_cpu_notify(struct notifier_block *self, ...@@ -209,7 +209,7 @@ static int __cpuinit blk_iopoll_cpu_notify(struct notifier_block *self,
return NOTIFY_OK; return NOTIFY_OK;
} }
static struct notifier_block __cpuinitdata blk_iopoll_cpu_notifier = { static struct notifier_block blk_iopoll_cpu_notifier = {
.notifier_call = blk_iopoll_cpu_notify, .notifier_call = blk_iopoll_cpu_notify,
}; };
......
...@@ -78,8 +78,8 @@ static int raise_blk_irq(int cpu, struct request *rq) ...@@ -78,8 +78,8 @@ static int raise_blk_irq(int cpu, struct request *rq)
} }
#endif #endif
static int __cpuinit blk_cpu_notify(struct notifier_block *self, static int blk_cpu_notify(struct notifier_block *self, unsigned long action,
unsigned long action, void *hcpu) void *hcpu)
{ {
/* /*
* If a CPU goes away, splice its entries to the current CPU * If a CPU goes away, splice its entries to the current CPU
...@@ -98,7 +98,7 @@ static int __cpuinit blk_cpu_notify(struct notifier_block *self, ...@@ -98,7 +98,7 @@ static int __cpuinit blk_cpu_notify(struct notifier_block *self,
return NOTIFY_OK; return NOTIFY_OK;
} }
static struct notifier_block __cpuinitdata blk_cpu_notifier = { static struct notifier_block blk_cpu_notifier = {
.notifier_call = blk_cpu_notify, .notifier_call = blk_cpu_notify,
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment