Commit 0c340ba0 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Mark Brown

ASoC: max98388: fix unused function warnings

The PM functions are never referenced when CONFIG_PM_SLEEP is
disabled:

sound/soc/codecs/max98388.c:854:12: error: unused function 'max98388_suspend' [-Werror,-Wunused-function]
static int max98388_suspend(struct device *dev)
           ^
sound/soc/codecs/max98388.c:864:12: error: unused function 'max98388_resume' [-Werror,-Wunused-function]
static int max98388_resume(struct device *dev)

Fix this by using the modern SYSTEM_SLEEP_PM_OPS() macro in place of
the deprecated SET_SYSTEM_SLEEP_PM_OPS() version, and use pm_sleep_ptr()
to hide the entire structure as well.

On a related note, the of_match_ptr() and ACPI_PTR() macros have the same
problem and would cause the device id table to be unused when the driver
is built-in and the respective subsystems are disabled. This does not
cause warnings unless -Wunused-const-variable is passed to the compiler,
but it's better to just not use the macros at all here.
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20230616090156.2347850-1-arnd@kernel.orgSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent fadccca8
...@@ -873,7 +873,7 @@ static int max98388_resume(struct device *dev) ...@@ -873,7 +873,7 @@ static int max98388_resume(struct device *dev)
} }
static const struct dev_pm_ops max98388_pm = { static const struct dev_pm_ops max98388_pm = {
SET_SYSTEM_SLEEP_PM_OPS(max98388_suspend, max98388_resume) SYSTEM_SLEEP_PM_OPS(max98388_suspend, max98388_resume)
}; };
static const struct regmap_config max98388_regmap = { static const struct regmap_config max98388_regmap = {
...@@ -998,9 +998,9 @@ MODULE_DEVICE_TABLE(acpi, max98388_acpi_match); ...@@ -998,9 +998,9 @@ MODULE_DEVICE_TABLE(acpi, max98388_acpi_match);
static struct i2c_driver max98388_i2c_driver = { static struct i2c_driver max98388_i2c_driver = {
.driver = { .driver = {
.name = "max98388", .name = "max98388",
.of_match_table = of_match_ptr(max98388_of_match), .of_match_table = max98388_of_match,
.acpi_match_table = ACPI_PTR(max98388_acpi_match), .acpi_match_table = max98388_acpi_match,
.pm = &max98388_pm, .pm = pm_sleep_ptr(&max98388_pm),
}, },
.probe = max98388_i2c_probe, .probe = max98388_i2c_probe,
.id_table = max98388_i2c_id, .id_table = max98388_i2c_id,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment