Commit 0c582408 authored by Himangi Saraogi's avatar Himangi Saraogi Committed by Felipe Balbi

usb: phy: drop kfree of devm_kzalloc's data

Using kfree to free data allocated with devm_kzalloc causes double frees.

The Coccinelle semantic patch that fixes this problem is as follows:

// <smpl>
@@
expression x;
@@

x = devm_kzalloc(...)
...
?-kfree(x);
// </smpl>
Reviewed-by: default avatarJingoo Han <jg1.han@samsung.com>
Acked-by: default avatarJulia Lawall <julia.lawall@lip6.fr>
Signed-off-by: default avatarHimangi Saraogi <himangi774@gmail.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent 2c4e3dbf
...@@ -260,10 +260,8 @@ static int gpio_vbus_probe(struct platform_device *pdev) ...@@ -260,10 +260,8 @@ static int gpio_vbus_probe(struct platform_device *pdev)
gpio_vbus->phy.otg = devm_kzalloc(&pdev->dev, sizeof(struct usb_otg), gpio_vbus->phy.otg = devm_kzalloc(&pdev->dev, sizeof(struct usb_otg),
GFP_KERNEL); GFP_KERNEL);
if (!gpio_vbus->phy.otg) { if (!gpio_vbus->phy.otg)
kfree(gpio_vbus);
return -ENOMEM; return -ENOMEM;
}
platform_set_drvdata(pdev, gpio_vbus); platform_set_drvdata(pdev, gpio_vbus);
gpio_vbus->dev = &pdev->dev; gpio_vbus->dev = &pdev->dev;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment