Commit 0c9441c4 authored by Nathan Huckleberry's avatar Nathan Huckleberry Committed by Jakub Kicinski

net: wwan: iosm: Fix return type of ipc_wwan_link_transmit

The ndo_start_xmit field in net_device_ops is expected to be of type
netdev_tx_t (*ndo_start_xmit)(struct sk_buff *skb, struct net_device *dev).

The mismatched return type breaks forward edge kCFI since the underlying
function definition does not match the function hook definition.

The return type of ipc_wwan_link_transmit should be changed from int to
netdev_tx_t.
Reported-by: default avatarDan Carpenter <error27@gmail.com>
Link: https://github.com/ClangBuiltLinux/linux/issues/1703
Cc: llvm@lists.linux.dev
Signed-off-by: default avatarNathan Huckleberry <nhuck@google.com>
Acked-by: default avatarSergey Ryazanov <ryazanov.s.a@gmail.com>
Link: https://lore.kernel.org/r/20220912214455.929028-1-nhuck@google.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 106c67ce
...@@ -103,8 +103,8 @@ static int ipc_wwan_link_stop(struct net_device *netdev) ...@@ -103,8 +103,8 @@ static int ipc_wwan_link_stop(struct net_device *netdev)
} }
/* Transmit a packet */ /* Transmit a packet */
static int ipc_wwan_link_transmit(struct sk_buff *skb, static netdev_tx_t ipc_wwan_link_transmit(struct sk_buff *skb,
struct net_device *netdev) struct net_device *netdev)
{ {
struct iosm_netdev_priv *priv = wwan_netdev_drvpriv(netdev); struct iosm_netdev_priv *priv = wwan_netdev_drvpriv(netdev);
struct iosm_wwan *ipc_wwan = priv->ipc_wwan; struct iosm_wwan *ipc_wwan = priv->ipc_wwan;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment