Commit 0daf5cb2 authored by Jiri Olsa's avatar Jiri Olsa Committed by Steven Rostedt

ftrace/samples: Add missing prototypes direct functions

There's another compilation fail (first here [1]) reported by kernel
test robot for W=1 clang build:

  >> samples/ftrace/ftrace-direct-multi-modify.c:7:6: warning: no previous
  prototype for function 'my_direct_func1' [-Wmissing-prototypes]
     void my_direct_func1(unsigned long ip)

Direct functions in ftrace direct sample modules need to have prototypes
defined. They are already global in order to be visible for the inline
assembly, so there's no problem.

The kernel test robot reported just error for ftrace-direct-multi-modify,
but I got same errors also for the rest of the modules touched by this patch.

[1] 67d4f6e3 ftrace/samples: Add missing prototype for my_direct_func

Link: https://lkml.kernel.org/r/20211219135317.212430-1-jolsa@kernel.orgReported-by: default avatarkernel test robot <lkp@intel.com>
Fixes: e1067a07 ("ftrace/samples: Add module to test multi direct modify interface")
Fixes: ae0cc3b7 ("ftrace/samples: Add a sample module that implements modify_ftrace_direct()")
Fixes: 156473a0 ("ftrace: Add another example of register_ftrace_direct() use case")
Fixes: b06457c8 ("ftrace: Add sample module that uses register_ftrace_direct()")
Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
Signed-off-by: default avatarSteven Rostedt <rostedt@goodmis.org>
parent c24be24a
...@@ -4,6 +4,9 @@ ...@@ -4,6 +4,9 @@
#include <linux/ftrace.h> #include <linux/ftrace.h>
#include <asm/asm-offsets.h> #include <asm/asm-offsets.h>
extern void my_direct_func1(void);
extern void my_direct_func2(void);
void my_direct_func1(void) void my_direct_func1(void)
{ {
trace_printk("my direct func1\n"); trace_printk("my direct func1\n");
......
...@@ -4,6 +4,9 @@ ...@@ -4,6 +4,9 @@
#include <linux/ftrace.h> #include <linux/ftrace.h>
#include <asm/asm-offsets.h> #include <asm/asm-offsets.h>
extern void my_direct_func1(unsigned long ip);
extern void my_direct_func2(unsigned long ip);
void my_direct_func1(unsigned long ip) void my_direct_func1(unsigned long ip)
{ {
trace_printk("my direct func1 ip %lx\n", ip); trace_printk("my direct func1 ip %lx\n", ip);
......
...@@ -5,6 +5,9 @@ ...@@ -5,6 +5,9 @@
#include <linux/ftrace.h> #include <linux/ftrace.h>
#include <asm/asm-offsets.h> #include <asm/asm-offsets.h>
extern void my_direct_func(struct vm_area_struct *vma,
unsigned long address, unsigned int flags);
void my_direct_func(struct vm_area_struct *vma, void my_direct_func(struct vm_area_struct *vma,
unsigned long address, unsigned int flags) unsigned long address, unsigned int flags)
{ {
......
...@@ -5,6 +5,8 @@ ...@@ -5,6 +5,8 @@
#include <linux/ftrace.h> #include <linux/ftrace.h>
#include <asm/asm-offsets.h> #include <asm/asm-offsets.h>
extern void my_direct_func(struct task_struct *p);
void my_direct_func(struct task_struct *p) void my_direct_func(struct task_struct *p)
{ {
trace_printk("waking up %s-%d\n", p->comm, p->pid); trace_printk("waking up %s-%d\n", p->comm, p->pid);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment