Commit 0e761b21 authored by Phil Carmody's avatar Phil Carmody Committed by Mauro Carvalho Chehab

[media] exynos4-is: Simplify bitmask usage

Merge the two sets of flags into one array to simplify accessing
arbitrary bits from them.
Signed-off-by: default avatarPhil Carmody <phil.carmody@partner.samsung.com>
Signed-off-by: default avatarSylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 5c327e73
...@@ -89,8 +89,8 @@ int fimc_is_hw_set_param(struct fimc_is *is) ...@@ -89,8 +89,8 @@ int fimc_is_hw_set_param(struct fimc_is *is)
mcuctl_write(is->config_index, is, MCUCTL_REG_ISSR(2)); mcuctl_write(is->config_index, is, MCUCTL_REG_ISSR(2));
mcuctl_write(param_count, is, MCUCTL_REG_ISSR(3)); mcuctl_write(param_count, is, MCUCTL_REG_ISSR(3));
mcuctl_write(config->p_region_index1, is, MCUCTL_REG_ISSR(4)); mcuctl_write(config->p_region_index[0], is, MCUCTL_REG_ISSR(4));
mcuctl_write(config->p_region_index2, is, MCUCTL_REG_ISSR(5)); mcuctl_write(config->p_region_index[1], is, MCUCTL_REG_ISSR(5));
fimc_is_hw_set_intgr0_gd0(is); fimc_is_hw_set_intgr0_gd0(is);
return 0; return 0;
......
...@@ -530,8 +530,8 @@ static void fimc_is_general_irq_handler(struct fimc_is *is) ...@@ -530,8 +530,8 @@ static void fimc_is_general_irq_handler(struct fimc_is *is)
break; break;
case HIC_SET_PARAMETER: case HIC_SET_PARAMETER:
is->config[is->config_index].p_region_index1 = 0; is->config[is->config_index].p_region_index[0] = 0;
is->config[is->config_index].p_region_index2 = 0; is->config[is->config_index].p_region_index[1] = 0;
set_bit(IS_ST_BLOCK_CMD_CLEARED, &is->state); set_bit(IS_ST_BLOCK_CMD_CLEARED, &is->state);
pr_debug("HIC_SET_PARAMETER\n"); pr_debug("HIC_SET_PARAMETER\n");
break; break;
...@@ -590,8 +590,8 @@ static void fimc_is_general_irq_handler(struct fimc_is *is) ...@@ -590,8 +590,8 @@ static void fimc_is_general_irq_handler(struct fimc_is *is)
switch (is->i2h_cmd.args[0]) { switch (is->i2h_cmd.args[0]) {
case HIC_SET_PARAMETER: case HIC_SET_PARAMETER:
is->config[is->config_index].p_region_index1 = 0; is->config[is->config_index].p_region_index[0] = 0;
is->config[is->config_index].p_region_index2 = 0; is->config[is->config_index].p_region_index[1] = 0;
set_bit(IS_ST_BLOCK_CMD_CLEARED, &is->state); set_bit(IS_ST_BLOCK_CMD_CLEARED, &is->state);
break; break;
} }
......
...@@ -226,8 +226,7 @@ struct chain_config { ...@@ -226,8 +226,7 @@ struct chain_config {
struct drc_param drc; struct drc_param drc;
struct fd_param fd; struct fd_param fd;
unsigned long p_region_index1; unsigned long p_region_index[2];
unsigned long p_region_index2;
}; };
/** /**
...@@ -304,10 +303,7 @@ static inline void fimc_is_set_param_bit(struct fimc_is *is, int num) ...@@ -304,10 +303,7 @@ static inline void fimc_is_set_param_bit(struct fimc_is *is, int num)
{ {
struct chain_config *cfg = &is->config[is->config_index]; struct chain_config *cfg = &is->config[is->config_index];
if (num >= 32) set_bit(num, &cfg->p_region_index[0]);
set_bit(num - 32, &cfg->p_region_index2);
else
set_bit(num, &cfg->p_region_index1);
} }
static inline void fimc_is_set_param_ctrl_cmd(struct fimc_is *is, int cmd) static inline void fimc_is_set_param_ctrl_cmd(struct fimc_is *is, int cmd)
......
...@@ -317,8 +317,8 @@ static int fimc_isp_subdev_s_power(struct v4l2_subdev *sd, int on) ...@@ -317,8 +317,8 @@ static int fimc_isp_subdev_s_power(struct v4l2_subdev *sd, int on)
clear_bit(IS_ST_PWR_ON, &is->state); clear_bit(IS_ST_PWR_ON, &is->state);
clear_bit(IS_ST_INIT_DONE, &is->state); clear_bit(IS_ST_INIT_DONE, &is->state);
is->state = 0; is->state = 0;
is->config[is->config_index].p_region_index1 = 0; is->config[is->config_index].p_region_index[0] = 0;
is->config[is->config_index].p_region_index2 = 0; is->config[is->config_index].p_region_index[1] = 0;
set_bit(IS_ST_IDLE, &is->state); set_bit(IS_ST_IDLE, &is->state);
wmb(); wmb();
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment