Commit 106c67ce authored by Nathan Huckleberry's avatar Nathan Huckleberry Committed by Jakub Kicinski

net: korina: Fix return type of korina_send_packet

The ndo_start_xmit field in net_device_ops is expected to be of type
netdev_tx_t (*ndo_start_xmit)(struct sk_buff *skb, struct net_device *dev).

The mismatched return type breaks forward edge kCFI since the underlying
function definition does not match the function hook definition.

The return type of korina_send_packet should be changed from int to
netdev_tx_t.
Reported-by: default avatarDan Carpenter <error27@gmail.com>
Link: https://github.com/ClangBuiltLinux/linux/issues/1703
Cc: llvm@lists.linux.dev
Signed-off-by: default avatarNathan Huckleberry <nhuck@google.com>
Reviewed-by: default avatarNathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20220912214344.928925-1-nhuck@google.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 40662333
...@@ -416,7 +416,8 @@ static void korina_abort_rx(struct net_device *dev) ...@@ -416,7 +416,8 @@ static void korina_abort_rx(struct net_device *dev)
} }
/* transmit packet */ /* transmit packet */
static int korina_send_packet(struct sk_buff *skb, struct net_device *dev) static netdev_tx_t korina_send_packet(struct sk_buff *skb,
struct net_device *dev)
{ {
struct korina_private *lp = netdev_priv(dev); struct korina_private *lp = netdev_priv(dev);
u32 chain_prev, chain_next; u32 chain_prev, chain_next;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment