Commit 10d09773 authored by Chris Packham's avatar Chris Packham Committed by Guenter Roeck

hwmon: (adm9240) Use loops to avoid duplicated code

Use loops for reading temp_max and initialising FAN_MIN/TEMP_MAX rather
than duplicating code.
Signed-off-by: default avatarChris Packham <chris.packham@alliedtelesis.co.nz>
Link: https://lore.kernel.org/r/20200924085102.15219-2-chris.packham@alliedtelesis.co.nzSigned-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 55163a1c
...@@ -223,10 +223,10 @@ static struct adm9240_data *adm9240_update_device(struct device *dev) ...@@ -223,10 +223,10 @@ static struct adm9240_data *adm9240_update_device(struct device *dev)
data->fan_min[i] = i2c_smbus_read_byte_data(client, data->fan_min[i] = i2c_smbus_read_byte_data(client,
ADM9240_REG_FAN_MIN(i)); ADM9240_REG_FAN_MIN(i));
} }
data->temp_max[0] = i2c_smbus_read_byte_data(client, for (i = 0; i < 2; i++) {
ADM9240_REG_TEMP_MAX(0)); data->temp_max[i] = i2c_smbus_read_byte_data(client,
data->temp_max[1] = i2c_smbus_read_byte_data(client, ADM9240_REG_TEMP_MAX(i));
ADM9240_REG_TEMP_MAX(1)); }
/* read fan divs and 5-bit VID */ /* read fan divs and 5-bit VID */
i = i2c_smbus_read_byte_data(client, ADM9240_REG_VID_FAN_DIV); i = i2c_smbus_read_byte_data(client, ADM9240_REG_VID_FAN_DIV);
...@@ -687,14 +687,14 @@ static void adm9240_init_client(struct i2c_client *client) ...@@ -687,14 +687,14 @@ static void adm9240_init_client(struct i2c_client *client)
i2c_smbus_write_byte_data(client, i2c_smbus_write_byte_data(client,
ADM9240_REG_IN_MAX(i), 255); ADM9240_REG_IN_MAX(i), 255);
} }
i2c_smbus_write_byte_data(client, for (i = 0; i < 2; i++) {
ADM9240_REG_FAN_MIN(0), 255); i2c_smbus_write_byte_data(client,
i2c_smbus_write_byte_data(client, ADM9240_REG_FAN_MIN(i), 255);
ADM9240_REG_FAN_MIN(1), 255); }
i2c_smbus_write_byte_data(client, for (i = 0; i < 2; i++) {
ADM9240_REG_TEMP_MAX(0), 127); i2c_smbus_write_byte_data(client,
i2c_smbus_write_byte_data(client, ADM9240_REG_TEMP_MAX(i), 127);
ADM9240_REG_TEMP_MAX(1), 127); }
/* start measurement cycle */ /* start measurement cycle */
i2c_smbus_write_byte_data(client, ADM9240_REG_CONFIG, 1); i2c_smbus_write_byte_data(client, ADM9240_REG_CONFIG, 1);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment