Commit 117aceb0 authored by Somasundaram Krishnasamy's avatar Somasundaram Krishnasamy Committed by Mike Snitzer

dm era: save spacemap metadata root after the pre-commit

When committing era metadata to disk, it doesn't always save the latest
spacemap metadata root in superblock. Due to this, metadata is getting
corrupted sometimes when reopening the device. The correct order of update
should be, pre-commit (shadows spacemap root), save the spacemap root
(newly shadowed block) to in-core superblock and then the final commit.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarSomasundaram Krishnasamy <somasundaram.krishnasamy@oracle.com>
Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
parent 948f581a
......@@ -961,15 +961,15 @@ static int metadata_commit(struct era_metadata *md)
}
}
r = save_sm_root(md);
r = dm_tm_pre_commit(md->tm);
if (r) {
DMERR("%s: save_sm_root failed", __func__);
DMERR("%s: pre commit failed", __func__);
return r;
}
r = dm_tm_pre_commit(md->tm);
r = save_sm_root(md);
if (r) {
DMERR("%s: pre commit failed", __func__);
DMERR("%s: save_sm_root failed", __func__);
return r;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment