Commit 119ae38a authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman

sound: hiface: move to use usb_control_msg_send()

The usb_control_msg_send() call can return an error if a "short" write
happens, so move the driver over to using that call instead.

Cc: Jaroslav Kysela <perex@perex.cz>
Reviewed-by: default avatarTakashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20200914153756.3412156-10-gregkh@linuxfoundation.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f7ef7614
...@@ -156,16 +156,14 @@ static int hiface_pcm_set_rate(struct pcm_runtime *rt, unsigned int rate) ...@@ -156,16 +156,14 @@ static int hiface_pcm_set_rate(struct pcm_runtime *rt, unsigned int rate)
* This control message doesn't have any ack from the * This control message doesn't have any ack from the
* other side * other side
*/ */
ret = usb_control_msg(device, usb_sndctrlpipe(device, 0), ret = usb_control_msg_send(device, 0,
HIFACE_SET_RATE_REQUEST, HIFACE_SET_RATE_REQUEST,
USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_OTHER, USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_OTHER,
rate_value, 0, NULL, 0, 100); rate_value, 0, NULL, 0, 100);
if (ret < 0) { if (ret)
dev_err(&device->dev, "Error setting samplerate %d.\n", rate); dev_err(&device->dev, "Error setting samplerate %d.\n", rate);
return ret;
}
return 0; return ret;
} }
static struct pcm_substream *hiface_pcm_get_substream(struct snd_pcm_substream static struct pcm_substream *hiface_pcm_get_substream(struct snd_pcm_substream
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment