Commit 11bce645 authored by Julia Lawall's avatar Julia Lawall Committed by Florian Tobias Schandinat

drivers/video/sunxvr2500.c: fix error return code

Initialize return variable before exiting on an error path.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}

// </smpl>
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarFlorian Tobias Schandinat <FlorianSchandinat@gmx.de>
parent 9ac5de0c
...@@ -181,8 +181,10 @@ static int __devinit s3d_pci_register(struct pci_dev *pdev, ...@@ -181,8 +181,10 @@ static int __devinit s3d_pci_register(struct pci_dev *pdev,
sp->fb_size = info->fix.line_length * sp->height; sp->fb_size = info->fix.line_length * sp->height;
sp->fb_base = ioremap(sp->fb_base_phys, sp->fb_size); sp->fb_base = ioremap(sp->fb_base_phys, sp->fb_size);
if (!sp->fb_base) if (!sp->fb_base) {
err = -ENOMEM;
goto err_release_pci; goto err_release_pci;
}
err = s3d_set_fbinfo(sp); err = s3d_set_fbinfo(sp);
if (err) if (err)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment