Commit 1255fcb2 authored by Ursula Braun's avatar Ursula Braun Committed by David S. Miller

net/smc: fix shutdown in state SMC_LISTEN

Calling shutdown with SHUT_RD and SHUT_RDWR for a listening SMC socket
crashes, because
   commit 127f4970 ("net/smc: release clcsock from tcp_listen_worker")
releases the internal clcsock in smc_close_active() and sets smc->clcsock
to NULL.
For SHUT_RD the smc_close_active() call is removed.
For SHUT_RDWR the kernel_sock_shutdown() call is omitted, since the
clcsock is already released.

Fixes: 127f4970 ("net/smc: release clcsock from tcp_listen_worker")
Signed-off-by: default avatarUrsula Braun <ubraun@linux.vnet.ibm.com>
Reported-by: default avatarStephen Hemminger <stephen@networkplumber.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a60faa60
...@@ -1259,14 +1259,12 @@ static int smc_shutdown(struct socket *sock, int how) ...@@ -1259,14 +1259,12 @@ static int smc_shutdown(struct socket *sock, int how)
rc = smc_close_shutdown_write(smc); rc = smc_close_shutdown_write(smc);
break; break;
case SHUT_RD: case SHUT_RD:
if (sk->sk_state == SMC_LISTEN) rc = 0;
rc = smc_close_active(smc); /* nothing more to do because peer is not involved */
else
rc = 0;
/* nothing more to do because peer is not involved */
break; break;
} }
rc1 = kernel_sock_shutdown(smc->clcsock, how); if (smc->clcsock)
rc1 = kernel_sock_shutdown(smc->clcsock, how);
/* map sock_shutdown_cmd constants to sk_shutdown value range */ /* map sock_shutdown_cmd constants to sk_shutdown value range */
sk->sk_shutdown |= how + 1; sk->sk_shutdown |= how + 1;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment