Commit 1456ba1d authored by Daniele Bellucci's avatar Daniele Bellucci Committed by Greg Kroah-Hartman

[PATCH] Audit and minor cleanups in drivers/usb/*

- if usb_register fails report back its return code rather than -1
- module_init/cleanup functions declared as static
- missing __init/__exit
parent 8bf77d4c
...@@ -433,14 +433,12 @@ static struct usb_driver powermate_driver = { ...@@ -433,14 +433,12 @@ static struct usb_driver powermate_driver = {
.id_table = powermate_devices, .id_table = powermate_devices,
}; };
int powermate_init(void) static int __init powermate_init(void)
{ {
if (usb_register(&powermate_driver) < 0) return usb_register(&powermate_driver);
return -1;
return 0;
} }
void powermate_cleanup(void) static void __exit powermate_cleanup(void)
{ {
usb_deregister(&powermate_driver); usb_deregister(&powermate_driver);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment