Commit 147fd9d6 authored by Wei Yongjun's avatar Wei Yongjun Committed by Kishon Vijay Abraham I

phy: fix return value check in armada375_usb_phy_probe()

In case of error, the function devm_ioremap_resource() returns
ERR_PTR() and never returns NULL. The NULL test in the return
value check should be replaced with IS_ERR().
Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: default avatarKishon Vijay Abraham I <kishon@ti.com>
parent 7f33912d
...@@ -118,8 +118,8 @@ static int armada375_usb_phy_probe(struct platform_device *pdev) ...@@ -118,8 +118,8 @@ static int armada375_usb_phy_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0); res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
usb_cluster_base = devm_ioremap_resource(&pdev->dev, res); usb_cluster_base = devm_ioremap_resource(&pdev->dev, res);
if (!usb_cluster_base) if (IS_ERR(usb_cluster_base))
return -ENOMEM; return PTR_ERR(usb_cluster_base);
phy = devm_phy_create(dev, NULL, &armada375_usb_phy_ops); phy = devm_phy_create(dev, NULL, &armada375_usb_phy_ops);
if (IS_ERR(phy)) { if (IS_ERR(phy)) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment