Commit 15107e44 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski

ARM: dts: exynos: correct MUIC interrupt trigger level on Midas family

The Maxim MUIC datasheets describe the interrupt line as active low
with a requirement of acknowledge from the CPU.  Without specifying the
interrupt type in Devicetree, kernel might apply some fixed
configuration, not necessarily working for this hardware.

Additionally, the interrupt line is shared so using level sensitive
interrupt is here especially important to avoid races.

Fixes: 7eec1266 ("ARM: dts: Add Maxim 77693 PMIC to exynos4412-trats2")
Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20201210212534.216197-4-krzk@kernel.org
parent 8a45f33b
...@@ -173,7 +173,7 @@ i2c_max77693: i2c-gpio-1 { ...@@ -173,7 +173,7 @@ i2c_max77693: i2c-gpio-1 {
pmic@66 { pmic@66 {
compatible = "maxim,max77693"; compatible = "maxim,max77693";
interrupt-parent = <&gpx1>; interrupt-parent = <&gpx1>;
interrupts = <5 IRQ_TYPE_EDGE_FALLING>; interrupts = <5 IRQ_TYPE_LEVEL_LOW>;
pinctrl-names = "default"; pinctrl-names = "default";
pinctrl-0 = <&max77693_irq>; pinctrl-0 = <&max77693_irq>;
reg = <0x66>; reg = <0x66>;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment