Commit 151fbcb9 authored by Jonathan Corbet's avatar Jonathan Corbet Committed by Greg Kroah-Hartman

drm/i915: Maintain consistent documentation subsection ordering

commit 551bd336 upstream.

With Sphinx 2.0 (or prior versions with the deprecation warnings fixed) the
docs build fails with:

  Documentation/gpu/i915.rst:403: WARNING: Title level inconsistent:

  Global GTT Fence Handling
  ~~~~~~~~~~~~~~~~~~~~~~~~~

  reST markup error:
  Documentation/gpu/i915.rst:403: (SEVERE/4) Title level inconsistent:

I "fixed" it by changing the subsections in i915.rst, but that didn't seem
like the correct change.  It turns out that a couple of i915 files create
their own subsections in kerneldoc comments using apostrophes as the
heading marker:

  Layout
  ''''''

That breaks the normal subsection marker ordering, and newer Sphinx is
rather more strict about enforcing that ordering.  So fix the offending
comments to make Sphinx happy.

(This is unfortunate, in that kerneldoc comments shouldn't need to be aware
of where they might be included in the heading hierarchy, but I don't see
a better way around it).

Cc: stable@vger.kernel.org  # v4.14+
Acked-by: default avatarJani Nikula <jani.nikula@intel.com>
Signed-off-by: default avatarJonathan Corbet <corbet@lwn.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 67150514
...@@ -32,7 +32,7 @@ ...@@ -32,7 +32,7 @@
* macros. Do **not** mass change existing definitions just to update the style. * macros. Do **not** mass change existing definitions just to update the style.
* *
* Layout * Layout
* '''''' * ~~~~~~
* *
* Keep helper macros near the top. For example, _PIPE() and friends. * Keep helper macros near the top. For example, _PIPE() and friends.
* *
...@@ -78,7 +78,7 @@ ...@@ -78,7 +78,7 @@
* style. Use lower case in hexadecimal values. * style. Use lower case in hexadecimal values.
* *
* Naming * Naming
* '''''' * ~~~~~~
* *
* Try to name registers according to the specs. If the register name changes in * Try to name registers according to the specs. If the register name changes in
* the specs from platform to another, stick to the original name. * the specs from platform to another, stick to the original name.
...@@ -96,7 +96,7 @@ ...@@ -96,7 +96,7 @@
* suffix to the name. For example, ``_SKL`` or ``_GEN8``. * suffix to the name. For example, ``_SKL`` or ``_GEN8``.
* *
* Examples * Examples
* '''''''' * ~~~~~~~~
* *
* (Note that the values in the example are indented using spaces instead of * (Note that the values in the example are indented using spaces instead of
* TABs to avoid misalignment in generated documentation. Use TABs in the * TABs to avoid misalignment in generated documentation. Use TABs in the
......
...@@ -37,7 +37,7 @@ ...@@ -37,7 +37,7 @@
* costly and simplifies things. We can revisit this in the future. * costly and simplifies things. We can revisit this in the future.
* *
* Layout * Layout
* '''''' * ~~~~~~
* *
* Keep things in this file ordered by WA type, as per the above (context, GT, * Keep things in this file ordered by WA type, as per the above (context, GT,
* display, register whitelist, batchbuffer). Then, inside each type, keep the * display, register whitelist, batchbuffer). Then, inside each type, keep the
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment