Commit 1586a587 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller

af_unix: do not report POLLOUT on listeners

poll(POLLOUT) on a listener should not report fd is ready for
a write().

This would break some applications using poll() and pfd.events = -1,
as they would not block in poll()
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Reported-by: default avatarAlan Burlison <Alan.Burlison@oracle.com>
Tested-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 742e0383
......@@ -326,9 +326,10 @@ static struct sock *unix_find_socket_byinode(struct inode *i)
return s;
}
static inline int unix_writable(struct sock *sk)
static int unix_writable(const struct sock *sk)
{
return (atomic_read(&sk->sk_wmem_alloc) << 2) <= sk->sk_sndbuf;
return sk->sk_state != TCP_LISTEN &&
(atomic_read(&sk->sk_wmem_alloc) << 2) <= sk->sk_sndbuf;
}
static void unix_write_space(struct sock *sk)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment