Commit 1611a52c authored by Julia Lawall's avatar Julia Lawall Committed by Greg Kroah-Hartman

Staging: wlan-ng: p80211wext.c: problem with IW_ENCODE_ALG_WEP

The expression !(ext->alg & IW_ENCODE_ALG_WEP) appears to be incorrect,
because there are several possible values for ext->alg that give 1 when
bit-anded with IW_ENCODE_ALG_WEP.  Therefore Richard Kennedy suggested to
rewrite the code with !=

Added \n at the end of the debug string as well.
Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Cc: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent f2b50b40
...@@ -1487,8 +1487,8 @@ static int p80211wext_set_encodeext(struct net_device *dev, ...@@ -1487,8 +1487,8 @@ static int p80211wext_set_encodeext(struct net_device *dev,
} }
if (ext->ext_flags & IW_ENCODE_EXT_SET_TX_KEY) { if (ext->ext_flags & IW_ENCODE_EXT_SET_TX_KEY) {
if (!(ext->alg & IW_ENCODE_ALG_WEP)) { if (ext->alg != IW_ENCODE_ALG_WEP) {
pr_debug("asked to set a non wep key :("); pr_debug("asked to set a non wep key :(\n");
return -EINVAL; return -EINVAL;
} }
if (idx) { if (idx) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment