Commit 16b376bb authored by James Simmons's avatar James Simmons Committed by Greg Kroah-Hartman

staging: lustre: convert kernelcomm group to unsigned int

The group variable was converted to an unsigned int in
libcfs_kkuc_group_add() to avoid a potential overflow.
The variable group is used in other kernelcomm functions
so it makes sense to convert the rest of the group
variables to unsigned int.
Signed-off-by: default avatarJames Simmons <jsimmons@infradead.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 17328956
...@@ -45,11 +45,11 @@ typedef int (*libcfs_kkuc_cb_t)(void *data, void *cb_arg); ...@@ -45,11 +45,11 @@ typedef int (*libcfs_kkuc_cb_t)(void *data, void *cb_arg);
/* Kernel methods */ /* Kernel methods */
int libcfs_kkuc_msg_put(struct file *fp, void *payload); int libcfs_kkuc_msg_put(struct file *fp, void *payload);
int libcfs_kkuc_group_put(int group, void *payload); int libcfs_kkuc_group_put(unsigned int group, void *payload);
int libcfs_kkuc_group_add(struct file *fp, int uid, unsigned int group, int libcfs_kkuc_group_add(struct file *fp, int uid, unsigned int group,
void *data, size_t data_len); void *data, size_t data_len);
int libcfs_kkuc_group_rem(int uid, int group); int libcfs_kkuc_group_rem(int uid, unsigned int group);
int libcfs_kkuc_group_foreach(int group, libcfs_kkuc_cb_t cb_func, int libcfs_kkuc_group_foreach(unsigned int group, libcfs_kkuc_cb_t cb_func,
void *cb_arg); void *cb_arg);
#endif /* __LUSTRE_KERNELCOMM_H__ */ #endif /* __LUSTRE_KERNELCOMM_H__ */
...@@ -145,7 +145,7 @@ int libcfs_kkuc_group_add(struct file *filp, int uid, unsigned int group, ...@@ -145,7 +145,7 @@ int libcfs_kkuc_group_add(struct file *filp, int uid, unsigned int group,
} }
EXPORT_SYMBOL(libcfs_kkuc_group_add); EXPORT_SYMBOL(libcfs_kkuc_group_add);
int libcfs_kkuc_group_rem(int uid, int group) int libcfs_kkuc_group_rem(int uid, unsigned int group)
{ {
struct kkuc_reg *reg, *next; struct kkuc_reg *reg, *next;
...@@ -180,7 +180,7 @@ int libcfs_kkuc_group_rem(int uid, int group) ...@@ -180,7 +180,7 @@ int libcfs_kkuc_group_rem(int uid, int group)
} }
EXPORT_SYMBOL(libcfs_kkuc_group_rem); EXPORT_SYMBOL(libcfs_kkuc_group_rem);
int libcfs_kkuc_group_put(int group, void *payload) int libcfs_kkuc_group_put(unsigned int group, void *payload)
{ {
struct kkuc_reg *reg; struct kkuc_reg *reg;
int rc = 0; int rc = 0;
...@@ -215,7 +215,7 @@ EXPORT_SYMBOL(libcfs_kkuc_group_put); ...@@ -215,7 +215,7 @@ EXPORT_SYMBOL(libcfs_kkuc_group_put);
* @param cb_func the function to be called. * @param cb_func the function to be called.
* @param cb_arg extra argument to be passed to the callback function. * @param cb_arg extra argument to be passed to the callback function.
*/ */
int libcfs_kkuc_group_foreach(int group, libcfs_kkuc_cb_t cb_func, int libcfs_kkuc_group_foreach(unsigned int group, libcfs_kkuc_cb_t cb_func,
void *cb_arg) void *cb_arg)
{ {
struct kkuc_reg *reg; struct kkuc_reg *reg;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment