Commit 170277c5 authored by Ziyang Xuan's avatar Ziyang Xuan Committed by Marc Kleine-Budde

can: raw: use guard clause to optimize nesting in raw_rcv()

We can use guard clause to optimize nesting codes like
if (condition) { ... } else { return; } in raw_rcv();
Signed-off-by: default avatarZiyang Xuan <william.xuanziyang@huawei.com>
Link: https://lore.kernel.org/all/0170ad1f07dbe838965df4274fce950980fa9d1f.1661584485.git.william.xuanziyang@huawei.comSigned-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent c28b3bff
...@@ -136,14 +136,13 @@ static void raw_rcv(struct sk_buff *oskb, void *data) ...@@ -136,14 +136,13 @@ static void raw_rcv(struct sk_buff *oskb, void *data)
/* eliminate multiple filter matches for the same skb */ /* eliminate multiple filter matches for the same skb */
if (this_cpu_ptr(ro->uniq)->skb == oskb && if (this_cpu_ptr(ro->uniq)->skb == oskb &&
this_cpu_ptr(ro->uniq)->skbcnt == can_skb_prv(oskb)->skbcnt) { this_cpu_ptr(ro->uniq)->skbcnt == can_skb_prv(oskb)->skbcnt) {
if (ro->join_filters) { if (!ro->join_filters)
this_cpu_inc(ro->uniq->join_rx_count); return;
/* drop frame until all enabled filters matched */
if (this_cpu_ptr(ro->uniq)->join_rx_count < ro->count) this_cpu_inc(ro->uniq->join_rx_count);
return; /* drop frame until all enabled filters matched */
} else { if (this_cpu_ptr(ro->uniq)->join_rx_count < ro->count)
return; return;
}
} else { } else {
this_cpu_ptr(ro->uniq)->skb = oskb; this_cpu_ptr(ro->uniq)->skb = oskb;
this_cpu_ptr(ro->uniq)->skbcnt = can_skb_prv(oskb)->skbcnt; this_cpu_ptr(ro->uniq)->skbcnt = can_skb_prv(oskb)->skbcnt;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment