Commit 17956b53 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman

usb: gadget: r8a66597: fix a loop in set_feature()

This loop is supposed to loop until if reads something other than
CS_IDST or until it times out after 30,000 attempts.  But because of
the || vs && bug, it will never time out and instead it will loop a
minimum of 30,000 times.

This bug is quite old but the code is only used in USB_DEVICE_TEST_MODE
so it probably doesn't affect regular usage.

Fixes: 96fe53ef ("usb: gadget: r8a66597-udc: add support for TEST_MODE")
Cc: stable <stable@vger.kernel.org>
Reviewed-by: default avatarYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Acked-by: default avatarFelipe Balbi <balbi@kernel.org>
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20210906094221.GA10957@kiliSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f5dfd98a
...@@ -1250,7 +1250,7 @@ static void set_feature(struct r8a66597 *r8a66597, struct usb_ctrlrequest *ctrl) ...@@ -1250,7 +1250,7 @@ static void set_feature(struct r8a66597 *r8a66597, struct usb_ctrlrequest *ctrl)
do { do {
tmp = r8a66597_read(r8a66597, INTSTS0) & CTSQ; tmp = r8a66597_read(r8a66597, INTSTS0) & CTSQ;
udelay(1); udelay(1);
} while (tmp != CS_IDST || timeout-- > 0); } while (tmp != CS_IDST && timeout-- > 0);
if (tmp == CS_IDST) if (tmp == CS_IDST)
r8a66597_bset(r8a66597, r8a66597_bset(r8a66597,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment