Commit 17f64331 authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Mark Brown

ASoC: rt711: remove warnings

cppcheck complains, use separate loop variable for sink and source ports

sound/soc/codecs/rt711-sdw.c:382:4: style: Variable 'i' is reassigned
a value before the old one has been used. [redundantAssignment]
 i = 0;
   ^
sound/soc/codecs/rt711-sdw.c:371:4: note: i is assigned
  i++;
   ^
sound/soc/codecs/rt711-sdw.c:382:4: note: i is overwritten
 i = 0;
   ^
Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: default avatarKai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: default avatarRander Wang <rander.wang@linux.intel.com>
Link: https://lore.kernel.org/r/20201111214318.150529-4-pierre-louis.bossart@linux.intel.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 4a550007
...@@ -338,7 +338,8 @@ static int rt711_update_status(struct sdw_slave *slave, ...@@ -338,7 +338,8 @@ static int rt711_update_status(struct sdw_slave *slave,
static int rt711_read_prop(struct sdw_slave *slave) static int rt711_read_prop(struct sdw_slave *slave)
{ {
struct sdw_slave_prop *prop = &slave->prop; struct sdw_slave_prop *prop = &slave->prop;
int nval, i; int nval;
int i, j;
u32 bit; u32 bit;
unsigned long addr; unsigned long addr;
struct sdw_dpn_prop *dpn; struct sdw_dpn_prop *dpn;
...@@ -379,15 +380,15 @@ static int rt711_read_prop(struct sdw_slave *slave) ...@@ -379,15 +380,15 @@ static int rt711_read_prop(struct sdw_slave *slave)
if (!prop->sink_dpn_prop) if (!prop->sink_dpn_prop)
return -ENOMEM; return -ENOMEM;
i = 0; j = 0;
dpn = prop->sink_dpn_prop; dpn = prop->sink_dpn_prop;
addr = prop->sink_ports; addr = prop->sink_ports;
for_each_set_bit(bit, &addr, 32) { for_each_set_bit(bit, &addr, 32) {
dpn[i].num = bit; dpn[j].num = bit;
dpn[i].type = SDW_DPN_FULL; dpn[j].type = SDW_DPN_FULL;
dpn[i].simple_ch_prep_sm = true; dpn[j].simple_ch_prep_sm = true;
dpn[i].ch_prep_timeout = 10; dpn[j].ch_prep_timeout = 10;
i++; j++;
} }
/* set the timeout values */ /* set the timeout values */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment