Commit 18834586 authored by Ricardo Koller's avatar Ricardo Koller Committed by Marc Zyngier

KVM: arm64: selftests: Add test for legacy GICv3 REDIST base partially above IPA range

Add a new test into vgic_init which checks that the first vcpu fails to
run if there is not sufficient REDIST space below the addressable IPA
range.  This only applies to the KVM_VGIC_V3_ADDR_TYPE_REDIST legacy API
as the required REDIST space is not know when setting the DIST region.

Note that using the REDIST_REGION API results in a different check at
first vcpu run: that the number of redist regions is enough for all
vcpus. And there is already a test for that case in, the first step of
test_v3_new_redist_regions.
Reviewed-by: default avatarEric Auger <eric.auger@redhat.com>
Signed-off-by: default avatarRicardo Koller <ricarkol@google.com>
Reviewed-by: default avatarAndrew Jones <drjones@redhat.com>
Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20211005011921.437353-11-ricarkol@google.com
parent 2dcd9aa1
...@@ -565,6 +565,39 @@ static void test_v3_last_bit_single_rdist(void) ...@@ -565,6 +565,39 @@ static void test_v3_last_bit_single_rdist(void)
vm_gic_destroy(&v); vm_gic_destroy(&v);
} }
/* Uses the legacy REDIST region API. */
static void test_v3_redist_ipa_range_check_at_vcpu_run(void)
{
struct vm_gic v;
int ret, i;
uint64_t addr;
v = vm_gic_create_with_vcpus(KVM_DEV_TYPE_ARM_VGIC_V3, 1);
/* Set space for 3 redists, we have 1 vcpu, so this succeeds. */
addr = max_phys_size - (3 * 2 * 0x10000);
kvm_device_access(v.gic_fd, KVM_DEV_ARM_VGIC_GRP_ADDR,
KVM_VGIC_V3_ADDR_TYPE_REDIST, &addr, true);
addr = 0x00000;
kvm_device_access(v.gic_fd, KVM_DEV_ARM_VGIC_GRP_ADDR,
KVM_VGIC_V3_ADDR_TYPE_DIST, &addr, true);
/* Add the rest of the VCPUs */
for (i = 1; i < NR_VCPUS; ++i)
vm_vcpu_add_default(v.vm, i, guest_code);
kvm_device_access(v.gic_fd, KVM_DEV_ARM_VGIC_GRP_CTRL,
KVM_DEV_ARM_VGIC_CTRL_INIT, NULL, true);
/* Attempt to run a vcpu without enough redist space. */
ret = run_vcpu(v.vm, 2);
TEST_ASSERT(ret && errno == EINVAL,
"redist base+size above PA range detected on 1st vcpu run");
vm_gic_destroy(&v);
}
/* /*
* Returns 0 if it's possible to create GIC device of a given type (V2 or V3). * Returns 0 if it's possible to create GIC device of a given type (V2 or V3).
*/ */
...@@ -616,6 +649,7 @@ void run_tests(uint32_t gic_dev_type) ...@@ -616,6 +649,7 @@ void run_tests(uint32_t gic_dev_type)
test_v3_typer_accesses(); test_v3_typer_accesses();
test_v3_last_bit_redist_regions(); test_v3_last_bit_redist_regions();
test_v3_last_bit_single_rdist(); test_v3_last_bit_single_rdist();
test_v3_redist_ipa_range_check_at_vcpu_run();
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment