Commit 19029f3f authored by ChenXiaoSong's avatar ChenXiaoSong Committed by Greg Kroah-Hartman

debugfs: use DEFINE_SHOW_ATTRIBUTE to define debugfs_regset32_fops

Use DEFINE_SHOW_ATTRIBUTE helper macro to simplify the code.
Signed-off-by: default avatarChenXiaoSong <chenxiaosong2@huawei.com>
Link: https://lore.kernel.org/r/20220923102554.2443452-1-chenxiaosong2@huawei.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d70590d5
...@@ -1121,7 +1121,7 @@ void debugfs_print_regs32(struct seq_file *s, const struct debugfs_reg32 *regs, ...@@ -1121,7 +1121,7 @@ void debugfs_print_regs32(struct seq_file *s, const struct debugfs_reg32 *regs,
} }
EXPORT_SYMBOL_GPL(debugfs_print_regs32); EXPORT_SYMBOL_GPL(debugfs_print_regs32);
static int debugfs_show_regset32(struct seq_file *s, void *data) static int debugfs_regset32_show(struct seq_file *s, void *data)
{ {
struct debugfs_regset32 *regset = s->private; struct debugfs_regset32 *regset = s->private;
...@@ -1136,17 +1136,7 @@ static int debugfs_show_regset32(struct seq_file *s, void *data) ...@@ -1136,17 +1136,7 @@ static int debugfs_show_regset32(struct seq_file *s, void *data)
return 0; return 0;
} }
static int debugfs_open_regset32(struct inode *inode, struct file *file) DEFINE_SHOW_ATTRIBUTE(debugfs_regset32);
{
return single_open(file, debugfs_show_regset32, inode->i_private);
}
static const struct file_operations fops_regset32 = {
.open = debugfs_open_regset32,
.read = seq_read,
.llseek = seq_lseek,
.release = single_release,
};
/** /**
* debugfs_create_regset32 - create a debugfs file that returns register values * debugfs_create_regset32 - create a debugfs file that returns register values
...@@ -1167,7 +1157,7 @@ void debugfs_create_regset32(const char *name, umode_t mode, ...@@ -1167,7 +1157,7 @@ void debugfs_create_regset32(const char *name, umode_t mode,
struct dentry *parent, struct dentry *parent,
struct debugfs_regset32 *regset) struct debugfs_regset32 *regset)
{ {
debugfs_create_file(name, mode, parent, regset, &fops_regset32); debugfs_create_file(name, mode, parent, regset, &debugfs_regset32_fops);
} }
EXPORT_SYMBOL_GPL(debugfs_create_regset32); EXPORT_SYMBOL_GPL(debugfs_create_regset32);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment