Commit 1a0b00d1 authored by Bob Peterson's avatar Bob Peterson Committed by Andreas Gruenbacher

gfs2: Only do glock put in gfs2_create_inode for free inodes

Before this patch, the error path of function gfs2_create_inode would
always calls gfs2_glock_put for the inode glock. That's good for inodes
that are free. But after they've been added to the vfs inodes, errors
will cause the inode to be evicted, and the evict will do the glock
put for us. If we do a glock put again, we can try to free the glock
while there are still references to it, e.g. revokes pending for
the transaction that created it.

This patch adds a check: if (free_vfs_inode) before the put, thus
solving the problem.
Signed-off-by: default avatarBob Peterson <rpeterso@redhat.com>
Signed-off-by: default avatarAndreas Gruenbacher <agruenba@redhat.com>
parent ea22eee4
...@@ -780,6 +780,7 @@ static int gfs2_create_inode(struct inode *dir, struct dentry *dentry, ...@@ -780,6 +780,7 @@ static int gfs2_create_inode(struct inode *dir, struct dentry *dentry,
fail_free_inode: fail_free_inode:
if (ip->i_gl) { if (ip->i_gl) {
glock_clear_object(ip->i_gl, ip); glock_clear_object(ip->i_gl, ip);
if (free_vfs_inode) /* else evict will do the put for us */
gfs2_glock_put(ip->i_gl); gfs2_glock_put(ip->i_gl);
} }
gfs2_rs_delete(ip, NULL); gfs2_rs_delete(ip, NULL);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment