Commit 1a2fdf1c authored by Artemy Kovalyov's avatar Artemy Kovalyov Committed by Greg Kroah-Hartman

IB/mlx5: Compare only index part of a memory window rkey

[ Upstream commit d623dfd2 ]

The InfiniBand Architecture Specification section 10.6.7.2.4 TYPE 2 MEMORY
WINDOWS says that if the CI supports the Base Memory Management Extensions
defined in this specification, the R_Key format for a Type 2 Memory Window
must consist of:

* 24 bit index in the most significant bits of the R_Key, which is owned
  by the CI, and
* 8 bit key in the least significant bits of the R_Key, which is owned by
  the Consumer.

This means that the kernel should compare only the index part of a R_Key
to determine equality with another R_Key.

Fixes: db570d7d ("IB/mlx5: Add ODP support to MW")
Signed-off-by: default avatarArtemy Kovalyov <artemyko@mellanox.com>
Signed-off-by: default avatarMoni Shoua <monis@mellanox.com>
Signed-off-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 5e04fcba
...@@ -711,6 +711,15 @@ struct pf_frame { ...@@ -711,6 +711,15 @@ struct pf_frame {
int depth; int depth;
}; };
static bool mkey_is_eq(struct mlx5_core_mkey *mmkey, u32 key)
{
if (!mmkey)
return false;
if (mmkey->type == MLX5_MKEY_MW)
return mlx5_base_mkey(mmkey->key) == mlx5_base_mkey(key);
return mmkey->key == key;
}
static int get_indirect_num_descs(struct mlx5_core_mkey *mmkey) static int get_indirect_num_descs(struct mlx5_core_mkey *mmkey)
{ {
struct mlx5_ib_mw *mw; struct mlx5_ib_mw *mw;
...@@ -760,7 +769,7 @@ static int pagefault_single_data_segment(struct mlx5_ib_dev *dev, ...@@ -760,7 +769,7 @@ static int pagefault_single_data_segment(struct mlx5_ib_dev *dev,
next_mr: next_mr:
mmkey = __mlx5_mr_lookup(dev->mdev, mlx5_base_mkey(key)); mmkey = __mlx5_mr_lookup(dev->mdev, mlx5_base_mkey(key));
if (!mmkey || mmkey->key != key) { if (!mkey_is_eq(mmkey, key)) {
mlx5_ib_dbg(dev, "failed to find mkey %x\n", key); mlx5_ib_dbg(dev, "failed to find mkey %x\n", key);
ret = -EFAULT; ret = -EFAULT;
goto srcu_unlock; goto srcu_unlock;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment