Commit 1afb9c53 authored by Viresh Kumar's avatar Viresh Kumar Committed by Eduardo Valentin

thermal/cpu_cooling: update policy limits if clipped_freq < policy->max

policy->max is the maximum allowed frequency defined by user and
clipped_freq is the maximum that thermal constraints allow.

If clipped_freq is lower than policy->max, then we need to readjust
policy->max.

But, if clipped_freq is greater than policy->max, we don't need to do
anything. We used to call cpufreq_verify_within_limits() in this case,
but it doesn't change anything in this case.

Lets skip this unnecessary call and write a comment that explains this.
Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarEduardo Valentin <edubezval@gmail.com>
parent abcbcc25
...@@ -229,9 +229,20 @@ static int cpufreq_thermal_notifier(struct notifier_block *nb, ...@@ -229,9 +229,20 @@ static int cpufreq_thermal_notifier(struct notifier_block *nb,
if (!cpumask_test_cpu(policy->cpu, &cpufreq_dev->allowed_cpus)) if (!cpumask_test_cpu(policy->cpu, &cpufreq_dev->allowed_cpus))
continue; continue;
/*
* policy->max is the maximum allowed frequency defined by user
* and clipped_freq is the maximum that thermal constraints
* allow.
*
* If clipped_freq is lower than policy->max, then we need to
* readjust policy->max.
*
* But, if clipped_freq is greater than policy->max, we don't
* need to do anything.
*/
clipped_freq = cpufreq_dev->clipped_freq; clipped_freq = cpufreq_dev->clipped_freq;
if (policy->max != clipped_freq) if (policy->max > clipped_freq)
cpufreq_verify_within_limits(policy, 0, clipped_freq); cpufreq_verify_within_limits(policy, 0, clipped_freq);
break; break;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment