Commit 1b672224 authored by Rashika Kheria's avatar Rashika Kheria Committed by Greg Kroah-Hartman

Staging: zram: Fix memory leak by refcount mismatch

As suggested by Minchan Kim and Jerome Marchand "The code in reset_store
get the block device (bdget_disk()) but it does not put it (bdput()) when
it's done using it. The usage count is therefore incremented but never
decremented."

This patch also puts bdput() for all error cases.
Acked-by: default avatarMinchan Kim <minchan@kernel.org>
Acked-by: default avatarJerome Marchand <jmarchan@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarRashika Kheria <rashika.kheria@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9df68292
...@@ -652,21 +652,30 @@ static ssize_t reset_store(struct device *dev, ...@@ -652,21 +652,30 @@ static ssize_t reset_store(struct device *dev,
return -ENOMEM; return -ENOMEM;
/* Do not reset an active device! */ /* Do not reset an active device! */
if (bdev->bd_holders) if (bdev->bd_holders) {
return -EBUSY; ret = -EBUSY;
goto out;
}
ret = kstrtou16(buf, 10, &do_reset); ret = kstrtou16(buf, 10, &do_reset);
if (ret) if (ret)
return ret; goto out;
if (!do_reset) if (!do_reset) {
return -EINVAL; ret = -EINVAL;
goto out;
}
/* Make sure all pending I/O is finished */ /* Make sure all pending I/O is finished */
fsync_bdev(bdev); fsync_bdev(bdev);
bdput(bdev);
zram_reset_device(zram, true); zram_reset_device(zram, true);
return len; return len;
out:
bdput(bdev);
return ret;
} }
static void __zram_make_request(struct zram *zram, struct bio *bio, int rw) static void __zram_make_request(struct zram *zram, struct bio *bio, int rw)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment