Commit 1c960876 authored by Dave Airlie's avatar Dave Airlie

drm/dp/mst: don't pass port into the path builder function

This is unnecessary and it makes it easier to see what is needed
from port.

also add blank line to make things nicer.
Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent 0c6dadbe
...@@ -1027,8 +1027,8 @@ static void drm_dp_check_port_guid(struct drm_dp_mst_branch *mstb, ...@@ -1027,8 +1027,8 @@ static void drm_dp_check_port_guid(struct drm_dp_mst_branch *mstb,
} }
} }
static void build_mst_prop_path(struct drm_dp_mst_port *port, static void build_mst_prop_path(const struct drm_dp_mst_branch *mstb,
struct drm_dp_mst_branch *mstb, int pnum,
char *proppath, char *proppath,
size_t proppath_size) size_t proppath_size)
{ {
...@@ -1041,7 +1041,7 @@ static void build_mst_prop_path(struct drm_dp_mst_port *port, ...@@ -1041,7 +1041,7 @@ static void build_mst_prop_path(struct drm_dp_mst_port *port,
snprintf(temp, sizeof(temp), "-%d", port_num); snprintf(temp, sizeof(temp), "-%d", port_num);
strlcat(proppath, temp, proppath_size); strlcat(proppath, temp, proppath_size);
} }
snprintf(temp, sizeof(temp), "-%d", port->port_num); snprintf(temp, sizeof(temp), "-%d", pnum);
strlcat(proppath, temp, proppath_size); strlcat(proppath, temp, proppath_size);
} }
...@@ -1113,7 +1113,8 @@ static void drm_dp_add_port(struct drm_dp_mst_branch *mstb, ...@@ -1113,7 +1113,8 @@ static void drm_dp_add_port(struct drm_dp_mst_branch *mstb,
if (created && !port->input) { if (created && !port->input) {
char proppath[255]; char proppath[255];
build_mst_prop_path(port, mstb, proppath, sizeof(proppath));
build_mst_prop_path(mstb, port->port_num, proppath, sizeof(proppath));
port->connector = (*mstb->mgr->cbs->add_connector)(mstb->mgr, port, proppath); port->connector = (*mstb->mgr->cbs->add_connector)(mstb->mgr, port, proppath);
if (port->port_num >= 8) { if (port->port_num >= 8) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment