Commit 1cc9bd68 authored by Steve French's avatar Steve French

make convert_delimiter use strchr instead of open-coding it

Take advantage of accelerated strchr() on arches that support it.

Also, no caller ever passes in a NULL pointer. Get rid of the unneeded
NULL pointer check.
Signed-off-by: default avatarJeff Layton <jlayton@redhat.com>
Signed-off-by: default avatarSteve French <smfrench@gmail.com>
parent b979aaa1
...@@ -1064,21 +1064,16 @@ static inline char CIFS_DIR_SEP(const struct cifs_sb_info *cifs_sb) ...@@ -1064,21 +1064,16 @@ static inline char CIFS_DIR_SEP(const struct cifs_sb_info *cifs_sb)
static inline void static inline void
convert_delimiter(char *path, char delim) convert_delimiter(char *path, char delim)
{ {
int i; char old_delim, *pos;
char old_delim;
if (path == NULL)
return;
if (delim == '/') if (delim == '/')
old_delim = '\\'; old_delim = '\\';
else else
old_delim = '/'; old_delim = '/';
for (i = 0; path[i] != '\0'; i++) { pos = path;
if (path[i] == old_delim) while ((pos = strchr(pos, old_delim)))
path[i] = delim; *pos = delim;
}
} }
#ifdef CONFIG_CIFS_STATS #ifdef CONFIG_CIFS_STATS
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment