Commit 1d67d7f6 authored by Lendacky, Thomas's avatar Lendacky, Thomas Committed by David S. Miller

amd-xgbe: Checkpatch fixes

This set of patches resolves some checks reported by the checkpatch
tool.
Signed-off-by: default avatarTom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 919d9db9
...@@ -328,7 +328,7 @@ void xgbe_debugfs_init(struct xgbe_prv_data *pdata) ...@@ -328,7 +328,7 @@ void xgbe_debugfs_init(struct xgbe_prv_data *pdata)
buf = kasprintf(GFP_KERNEL, "amd-xgbe-%s", pdata->netdev->name); buf = kasprintf(GFP_KERNEL, "amd-xgbe-%s", pdata->netdev->name);
pdata->xgbe_debugfs = debugfs_create_dir(buf, NULL); pdata->xgbe_debugfs = debugfs_create_dir(buf, NULL);
if (pdata->xgbe_debugfs == NULL) { if (!pdata->xgbe_debugfs) {
netdev_err(pdata->netdev, "debugfs_create_dir failed\n"); netdev_err(pdata->netdev, "debugfs_create_dir failed\n");
return; return;
} }
......
...@@ -692,7 +692,7 @@ static void xgbe_adjust_link(struct net_device *netdev) ...@@ -692,7 +692,7 @@ static void xgbe_adjust_link(struct net_device *netdev)
struct phy_device *phydev = pdata->phydev; struct phy_device *phydev = pdata->phydev;
int new_state = 0; int new_state = 0;
if (phydev == NULL) if (!phydev)
return; return;
if (phydev->link) { if (phydev->link) {
......
...@@ -220,7 +220,7 @@ int xgbe_mdio_register(struct xgbe_prv_data *pdata) ...@@ -220,7 +220,7 @@ int xgbe_mdio_register(struct xgbe_prv_data *pdata)
} }
mii = mdiobus_alloc(); mii = mdiobus_alloc();
if (mii == NULL) { if (!mii) {
dev_err(pdata->dev, "mdiobus_alloc failed\n"); dev_err(pdata->dev, "mdiobus_alloc failed\n");
ret = -ENOMEM; ret = -ENOMEM;
goto err_node_get; goto err_node_get;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment