Commit 1d7a7128 authored by Qiushi Wu's avatar Qiushi Wu Committed by Sebastian Reichel

power: supply: core: fix memory leak in HWMON error path

In function power_supply_add_hwmon_sysfs(), psyhw->props is
allocated by bitmap_zalloc(). But this pointer is not deallocated
when devm_add_action fail,  which lead to a memory leak bug. To fix
this, we replace devm_add_action with devm_add_action_or_reset.

Cc: stable@kernel.org
Fixes: e67d4dfc ("power: supply: Add HWMON compatibility layer")
Signed-off-by: default avatarQiushi Wu <wu000273@umn.edu>
Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.com>
parent 21d4cdf8
...@@ -358,7 +358,7 @@ int power_supply_add_hwmon_sysfs(struct power_supply *psy) ...@@ -358,7 +358,7 @@ int power_supply_add_hwmon_sysfs(struct power_supply *psy)
goto error; goto error;
} }
ret = devm_add_action(dev, power_supply_hwmon_bitmap_free, ret = devm_add_action_or_reset(dev, power_supply_hwmon_bitmap_free,
psyhw->props); psyhw->props);
if (ret) if (ret)
goto error; goto error;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment