Commit 1dce520a authored by Jinjie Ruan's avatar Jinjie Ruan Committed by Paolo Abeni

net: phy: Use for_each_available_child_of_node_scoped()

Avoid need to manually handle of_node_put() by using
for_each_available_child_of_node_scoped(), which can simplfy code.
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Reviewed-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: default avatarJinjie Ruan <ruanjinjie@huawei.com>
Reviewed-by: default avatarFlorian Fainelli <florian.fainelli@broadcom.com>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 51c88429
...@@ -3407,7 +3407,7 @@ static int of_phy_led(struct phy_device *phydev, ...@@ -3407,7 +3407,7 @@ static int of_phy_led(struct phy_device *phydev,
static int of_phy_leds(struct phy_device *phydev) static int of_phy_leds(struct phy_device *phydev)
{ {
struct device_node *node = phydev->mdio.dev.of_node; struct device_node *node = phydev->mdio.dev.of_node;
struct device_node *leds, *led; struct device_node *leds;
int err; int err;
if (!IS_ENABLED(CONFIG_OF_MDIO)) if (!IS_ENABLED(CONFIG_OF_MDIO))
...@@ -3420,10 +3420,9 @@ static int of_phy_leds(struct phy_device *phydev) ...@@ -3420,10 +3420,9 @@ static int of_phy_leds(struct phy_device *phydev)
if (!leds) if (!leds)
return 0; return 0;
for_each_available_child_of_node(leds, led) { for_each_available_child_of_node_scoped(leds, led) {
err = of_phy_led(phydev, led); err = of_phy_led(phydev, led);
if (err) { if (err) {
of_node_put(led);
phy_leds_unregister(phydev); phy_leds_unregister(phydev);
return err; return err;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment