Commit 1eaf5faa authored by Chengguang Xu's avatar Chengguang Xu Committed by Jan Kara

ext2: optimize ext2_xattr_get()

Since xattr entry names are sorted, we don't have
to continue when current entry name is greater than
target.
Signed-off-by: default avatarChengguang Xu <cgxu519@zoho.com.cn>
Signed-off-by: default avatarJan Kara <jack@suse.cz>
parent d561d4dd
...@@ -199,7 +199,7 @@ ext2_xattr_get(struct inode *inode, int name_index, const char *name, ...@@ -199,7 +199,7 @@ ext2_xattr_get(struct inode *inode, int name_index, const char *name,
struct ext2_xattr_entry *entry; struct ext2_xattr_entry *entry;
size_t name_len, size; size_t name_len, size;
char *end; char *end;
int error; int error, not_found;
struct mb_cache *ea_block_cache = EA_BLOCK_CACHE(inode); struct mb_cache *ea_block_cache = EA_BLOCK_CACHE(inode);
ea_idebug(inode, "name=%d.%s, buffer=%p, buffer_size=%ld", ea_idebug(inode, "name=%d.%s, buffer=%p, buffer_size=%ld",
...@@ -238,10 +238,14 @@ ext2_xattr_get(struct inode *inode, int name_index, const char *name, ...@@ -238,10 +238,14 @@ ext2_xattr_get(struct inode *inode, int name_index, const char *name,
if (!ext2_xattr_entry_valid(entry, end, if (!ext2_xattr_entry_valid(entry, end,
inode->i_sb->s_blocksize)) inode->i_sb->s_blocksize))
goto bad_block; goto bad_block;
if (name_index == entry->e_name_index &&
name_len == entry->e_name_len && not_found = ext2_xattr_cmp_entry(name_index, name_len, name,
memcmp(name, entry->e_name, name_len) == 0) entry);
if (!not_found)
goto found; goto found;
if (not_found < 0)
break;
entry = EXT2_XATTR_NEXT(entry); entry = EXT2_XATTR_NEXT(entry);
} }
if (ext2_xattr_cache_insert(ea_block_cache, bh)) if (ext2_xattr_cache_insert(ea_block_cache, bh))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment