Commit 1ecf0d0c authored by Roel Kluin's avatar Roel Kluin Committed by Linus Torvalds

dz: test after postfix decrement fails in dz_console_putchar()

When loops reaches 0 the postfix decrement still subtracts, so the subsequent
test fails.
Signed-off-by: default avatarRoel Kluin <12o3l@tiscali.nl>
Acked-by: default avatarMaciej W. Rozycki <macro@linux-mips.org>
Cc: Johannes Weiner <hannes@saeurebad.de>
Cc: <stable@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 556637cd
...@@ -819,7 +819,7 @@ static void dz_console_putchar(struct uart_port *uport, int ch) ...@@ -819,7 +819,7 @@ static void dz_console_putchar(struct uart_port *uport, int ch)
dz_out(dport, DZ_TCR, mask); dz_out(dport, DZ_TCR, mask);
iob(); iob();
udelay(2); udelay(2);
} while (loops--); } while (--loops);
if (loops) /* Cannot send otherwise. */ if (loops) /* Cannot send otherwise. */
dz_out(dport, DZ_TDR, ch); dz_out(dport, DZ_TDR, ch);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment