Commit 1f20bf59 authored by Linus Walleij's avatar Linus Walleij

drm/panel: s6e63m0: Support max-brightness

The "max-brightness" is a standard backlight property that
we need to support for the Samsung GT-I8190 Golden because
the display will go black if we crank up the brightness
too high.

As the platform needs this ability to give picture this is
a regression fix along with the addition of the property
to the GT-I8190 device tree.

Cc: Stephan Gerhold <stephan@gerhold.net>
Fixes: 9c3f0a0d ("drm/panel: s6e63m0: Implement 28 backlight levels")
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Reviewed-by: default avatarSam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20201214222210.238081-1-linus.walleij@linaro.org
parent ce90f685
...@@ -692,12 +692,12 @@ static const struct backlight_ops s6e63m0_backlight_ops = { ...@@ -692,12 +692,12 @@ static const struct backlight_ops s6e63m0_backlight_ops = {
.update_status = s6e63m0_set_brightness, .update_status = s6e63m0_set_brightness,
}; };
static int s6e63m0_backlight_register(struct s6e63m0 *ctx) static int s6e63m0_backlight_register(struct s6e63m0 *ctx, u32 max_brightness)
{ {
struct backlight_properties props = { struct backlight_properties props = {
.type = BACKLIGHT_RAW, .type = BACKLIGHT_RAW,
.brightness = MAX_BRIGHTNESS, .brightness = max_brightness,
.max_brightness = MAX_BRIGHTNESS .max_brightness = max_brightness,
}; };
struct device *dev = ctx->dev; struct device *dev = ctx->dev;
int ret = 0; int ret = 0;
...@@ -719,6 +719,7 @@ int s6e63m0_probe(struct device *dev, ...@@ -719,6 +719,7 @@ int s6e63m0_probe(struct device *dev,
bool dsi_mode) bool dsi_mode)
{ {
struct s6e63m0 *ctx; struct s6e63m0 *ctx;
u32 max_brightness;
int ret; int ret;
ctx = devm_kzalloc(dev, sizeof(struct s6e63m0), GFP_KERNEL); ctx = devm_kzalloc(dev, sizeof(struct s6e63m0), GFP_KERNEL);
...@@ -734,6 +735,14 @@ int s6e63m0_probe(struct device *dev, ...@@ -734,6 +735,14 @@ int s6e63m0_probe(struct device *dev,
ctx->enabled = false; ctx->enabled = false;
ctx->prepared = false; ctx->prepared = false;
ret = device_property_read_u32(dev, "max-brightness", &max_brightness);
if (ret)
max_brightness = MAX_BRIGHTNESS;
if (max_brightness > MAX_BRIGHTNESS) {
dev_err(dev, "illegal max brightness specified\n");
max_brightness = MAX_BRIGHTNESS;
}
ctx->supplies[0].supply = "vdd3"; ctx->supplies[0].supply = "vdd3";
ctx->supplies[1].supply = "vci"; ctx->supplies[1].supply = "vci";
ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(ctx->supplies), ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(ctx->supplies),
...@@ -753,7 +762,7 @@ int s6e63m0_probe(struct device *dev, ...@@ -753,7 +762,7 @@ int s6e63m0_probe(struct device *dev,
dsi_mode ? DRM_MODE_CONNECTOR_DSI : dsi_mode ? DRM_MODE_CONNECTOR_DSI :
DRM_MODE_CONNECTOR_DPI); DRM_MODE_CONNECTOR_DPI);
ret = s6e63m0_backlight_register(ctx); ret = s6e63m0_backlight_register(ctx, max_brightness);
if (ret < 0) if (ret < 0)
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment