Commit 1f7b0a84 authored by Andreas Gruenbacher's avatar Andreas Gruenbacher

gfs2: Clean up quota.c:print_message

Function print_message() in quota.c doesn't return a meaningful return
value.  Turn it into a void function and stop abusing it for setting
variable error to 0 in gfs2_quota_check().
Signed-off-by: default avatarAndreas Gruenbacher <agruenba@redhat.com>
parent f7e4c610
...@@ -1190,17 +1190,16 @@ void gfs2_quota_unlock(struct gfs2_inode *ip) ...@@ -1190,17 +1190,16 @@ void gfs2_quota_unlock(struct gfs2_inode *ip)
#define MAX_LINE 256 #define MAX_LINE 256
static int print_message(struct gfs2_quota_data *qd, char *type) static void print_message(struct gfs2_quota_data *qd, char *type)
{ {
struct gfs2_sbd *sdp = qd->qd_sbd; struct gfs2_sbd *sdp = qd->qd_sbd;
if (sdp->sd_args.ar_quota != GFS2_QUOTA_QUIET) if (sdp->sd_args.ar_quota != GFS2_QUOTA_QUIET) {
fs_info(sdp, "quota %s for %s %u\n", fs_info(sdp, "quota %s for %s %u\n",
type, type,
(qd->qd_id.type == USRQUOTA) ? "user" : "group", (qd->qd_id.type == USRQUOTA) ? "user" : "group",
from_kqid(&init_user_ns, qd->qd_id)); from_kqid(&init_user_ns, qd->qd_id));
}
return 0;
} }
/** /**
...@@ -1270,7 +1269,8 @@ int gfs2_quota_check(struct gfs2_inode *ip, kuid_t uid, kgid_t gid, ...@@ -1270,7 +1269,8 @@ int gfs2_quota_check(struct gfs2_inode *ip, kuid_t uid, kgid_t gid,
* HZ)) { * HZ)) {
quota_send_warning(qd->qd_id, quota_send_warning(qd->qd_id,
sdp->sd_vfs->s_dev, QUOTA_NL_BSOFTWARN); sdp->sd_vfs->s_dev, QUOTA_NL_BSOFTWARN);
error = print_message(qd, "warning"); print_message(qd, "warning");
error = 0;
qd->qd_last_warn = jiffies; qd->qd_last_warn = jiffies;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment