Commit 2055a99d authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by David S. Miller

net: bonding: fix error return code of bond_neigh_init()

When slave is NULL or slave_ops->ndo_neigh_setup is NULL, no error
return code of bond_neigh_init() is assigned.
To fix this bug, ret is assigned with -EINVAL in these cases.

Fixes: 9e99bfef ("bonding: fix bond_neigh_init()")
Reported-by: default avatarTOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 29d98f54
...@@ -3978,11 +3978,15 @@ static int bond_neigh_init(struct neighbour *n) ...@@ -3978,11 +3978,15 @@ static int bond_neigh_init(struct neighbour *n)
rcu_read_lock(); rcu_read_lock();
slave = bond_first_slave_rcu(bond); slave = bond_first_slave_rcu(bond);
if (!slave) if (!slave) {
ret = -EINVAL;
goto out; goto out;
}
slave_ops = slave->dev->netdev_ops; slave_ops = slave->dev->netdev_ops;
if (!slave_ops->ndo_neigh_setup) if (!slave_ops->ndo_neigh_setup) {
ret = -EINVAL;
goto out; goto out;
}
/* TODO: find another way [1] to implement this. /* TODO: find another way [1] to implement this.
* Passing a zeroed structure is fragile, * Passing a zeroed structure is fragile,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment