Commit 20979202 authored by Pan Bian's avatar Pan Bian Committed by Stephen Boyd

clk: clk-wm831x: fix a logic error

Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188561. Function
wm831x_clkout_is_prepared() returns "true" when it fails to read
CLOCK_CONTROL_1. "true" means the device is already prepared. So
return "true" on the read failure seems improper.
Signed-off-by: default avatarPan Bian <bianpan2016@163.com>
Acked-by: default avatarCharles Keepax <ckeepax@opensource.wolfsonmicro.com>
Fixes: f05259a6 ("clk: wm831x: Add initial WM831x clock driver")
Signed-off-by: default avatarStephen Boyd <sboyd@codeaurora.org>
parent 1221ae21
...@@ -243,7 +243,7 @@ static int wm831x_clkout_is_prepared(struct clk_hw *hw) ...@@ -243,7 +243,7 @@ static int wm831x_clkout_is_prepared(struct clk_hw *hw)
if (ret < 0) { if (ret < 0) {
dev_err(wm831x->dev, "Unable to read CLOCK_CONTROL_1: %d\n", dev_err(wm831x->dev, "Unable to read CLOCK_CONTROL_1: %d\n",
ret); ret);
return true; return false;
} }
return (ret & WM831X_CLKOUT_ENA) != 0; return (ret & WM831X_CLKOUT_ENA) != 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment