Commit 213cf90b authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Mauro Carvalho Chehab

[media] omap3isp: preview: Skip brightness and contrast in configuration ioctl

Brightness and contrast are handled through V4L2 controls. Their
configuration bit in the preview engine update attributes table is set
to -1 to reflect that. However, the VIDIOC_OMAP3ISP_PRV_CFG ioctl
handler doesn't handle -1 correctly as a configuration bit value, and
erroneously considers that the parameter has been selected for update by
the ioctl caller. Fix this.
Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: default avatarSakari Ailus <sakari.ailus@iki.fi>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent ca7f4a38
......@@ -903,7 +903,7 @@ static int preview_config(struct isp_prev_device *prev,
attr = &update_attrs[i];
bit = 0;
if (!(cfg->update & attr->cfg_bit))
if (attr->cfg_bit == -1 || !(cfg->update & attr->cfg_bit))
continue;
bit = cfg->flag & attr->cfg_bit;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment