Commit 214f995c authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Mauro Carvalho Chehab

media: ti-vpe: cal: Add comments to cal_probe() to delimitate sections

The cal_probe() function is a bit long, add comments to delimitate
sections in order to improve readability. The platform_set_drvdata()
call is moved to a more logical place as a result.
Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
Reviewed-by: default avatarBenoit Parrot <bparrot@ti.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 6963e46c
...@@ -2309,9 +2309,10 @@ static int cal_probe(struct platform_device *pdev) ...@@ -2309,9 +2309,10 @@ static int cal_probe(struct platform_device *pdev)
return -ENODEV; return -ENODEV;
} }
/* save pdev pointer */
cal->pdev = pdev; cal->pdev = pdev;
platform_set_drvdata(pdev, cal);
/* Acquire resources: clocks, CAMERARX regmap, I/O memory and IRQ. */
cal->fclk = devm_clk_get(&pdev->dev, "fck"); cal->fclk = devm_clk_get(&pdev->dev, "fck");
if (IS_ERR(cal->fclk)) { if (IS_ERR(cal->fclk)) {
dev_err(&pdev->dev, "cannot get CAL fclk\n"); dev_err(&pdev->dev, "cannot get CAL fclk\n");
...@@ -2338,14 +2339,14 @@ static int cal_probe(struct platform_device *pdev) ...@@ -2338,14 +2339,14 @@ static int cal_probe(struct platform_device *pdev)
if (ret) if (ret)
return ret; return ret;
platform_set_drvdata(pdev, cal); /* Create CAMERARX PHYs. */
for (i = 0; i < cal->data->num_csi2_phy; ++i) { for (i = 0; i < cal->data->num_csi2_phy; ++i) {
cal->phy[i] = cal_camerarx_create(cal, i); cal->phy[i] = cal_camerarx_create(cal, i);
if (IS_ERR(cal->phy[i])) if (IS_ERR(cal->phy[i]))
return PTR_ERR(cal->phy[i]); return PTR_ERR(cal->phy[i]);
} }
/* Create contexts. */
for (i = 0; i < cal->data->num_csi2_phy; ++i) for (i = 0; i < cal->data->num_csi2_phy; ++i)
cal->ctx[i] = cal_create_instance(cal, i); cal->ctx[i] = cal_create_instance(cal, i);
...@@ -2356,15 +2357,13 @@ static int cal_probe(struct platform_device *pdev) ...@@ -2356,15 +2357,13 @@ static int cal_probe(struct platform_device *pdev)
vb2_dma_contig_set_max_seg_size(&pdev->dev, DMA_BIT_MASK(32)); vb2_dma_contig_set_max_seg_size(&pdev->dev, DMA_BIT_MASK(32));
/* Read the revision and hardware info to verify hardware access. */
pm_runtime_enable(&pdev->dev); pm_runtime_enable(&pdev->dev);
ret = pm_runtime_get_sync(&pdev->dev); ret = pm_runtime_get_sync(&pdev->dev);
if (ret) if (ret)
goto runtime_disable; goto runtime_disable;
/* Just check we can actually access the module */
cal_get_hwinfo(cal); cal_get_hwinfo(cal);
pm_runtime_put_sync(&pdev->dev); pm_runtime_put_sync(&pdev->dev);
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment