Commit 22f3571c authored by Marek Szyprowski's avatar Marek Szyprowski Committed by Bjorn Helgaas

PCI: exynos: Correct generic PHY usage

The proper initialization for generic PHYs is to call first phy_init(),
then phy_power_on().

While touching this, remove the phy_reset() call. It is just a left-over
from the obsoleted Exynos5440 support and the current exynos-pcie PHY
driver doesn't even support this function. It is also rarely used by other
drivers.

Link: https://lore.kernel.org/r/20220628220409.26545-2-m.szyprowski@samsung.comReported-by: default avatarBjorn Helgaas <helgaas@kernel.org>
Signed-off-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarChanho Park <chanho61.park@samsung.com>
Acked-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
parent f2812227
...@@ -258,9 +258,8 @@ static int exynos_pcie_host_init(struct dw_pcie_rp *pp) ...@@ -258,9 +258,8 @@ static int exynos_pcie_host_init(struct dw_pcie_rp *pp)
exynos_pcie_assert_core_reset(ep); exynos_pcie_assert_core_reset(ep);
phy_reset(ep->phy);
phy_power_on(ep->phy);
phy_init(ep->phy); phy_init(ep->phy);
phy_power_on(ep->phy);
exynos_pcie_deassert_core_reset(ep); exynos_pcie_deassert_core_reset(ep);
exynos_pcie_enable_irq_pulse(ep); exynos_pcie_enable_irq_pulse(ep);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment