Commit 2306f5d0 authored by Deepak R Varma's avatar Deepak R Varma Committed by Thomas Zimmermann

drm/sprd: remove redundant error logging

A call to platform_get_irq() already prints an error on failure within
its own implementation. So printing another error based on its return
value in the caller is redundant and should be removed. The clean up
also makes if condition block braces unnecessary. Remove that as well.

Issue identified using platform_get_irq.cocci coccicheck script.
Signed-off-by: default avatarDeepak R Varma <drv@mailo.com>
Reviewed-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/Y5XhPJ39ipMCcctq@qemulion
parent 5f70ba02
...@@ -803,10 +803,8 @@ static int sprd_dpu_context_init(struct sprd_dpu *dpu, ...@@ -803,10 +803,8 @@ static int sprd_dpu_context_init(struct sprd_dpu *dpu,
} }
ctx->irq = platform_get_irq(pdev, 0); ctx->irq = platform_get_irq(pdev, 0);
if (ctx->irq < 0) { if (ctx->irq < 0)
dev_err(dev, "failed to get dpu irq\n");
return ctx->irq; return ctx->irq;
}
/* disable and clear interrupts before register dpu IRQ. */ /* disable and clear interrupts before register dpu IRQ. */
writel(0x00, ctx->base + REG_DPU_INT_EN); writel(0x00, ctx->base + REG_DPU_INT_EN);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment